Problem: print_log tasks keep reading after vm end #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olethanh
force-pushed
the
fix_print_logs
branch
from
72af61f
to
ab27d24
Compare
hoh
reviewed
Nov 9, 2023
|
Can you rebase this branch on |
hoh
approved these changes
Nov 17, 2023
After the vm proc and the related stdout and stderr were closed the task keep trying to read them, creating a busy loop which wasted cpu. Solution: end the task when the file descriptor is closed
olethanh
force-pushed
the
fix_print_logs
branch
from
e985d5f
to
15afe99
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the vm proc and the related stdout and stderr were closed the task keep trying to read them, creating a busy loop which wasted cpu.
Solution: end the task when the file descriptor is closed